FishEye and Crucible

Sorry last jar. Thank you.

Misha

Hi. This is what I believe the patch should be.

Unfortunately your 1.0 version did not quite work, as for some reason you deleted the file metadata/moduleApplicationCtext.xml completely

However, I am more than happy to give you credit for the patch, as I like your:

• comments
• idea to use the patient that actually already exists in default OpenMRS database
  quite a bit.

I have made the libs for version 1.6.0 as I believe Darius advised me to use 1.6.0 for my spreadsheetimport module on IRC chat.

http://wiki.openmrs.org/display/IRC/2010-08-20

20:23:08 <misha680> ok here's a more important question... BasicModule uses OpenMRS 1.5 API. It seems to differ quite a bit from trunk. Which API version should new modules use (i.e., which would help most existing users)? Thank you
20:23:42 <chopin> foo
20:23:56 <nribeka> trunk
20:24:02 <downeym> bar
20:24:04 <nribeka> i cast my vote on trunk
20:24:23 <djazayeri> I would say start with 1.6
20:24:41 <djazayeri> if you run into a bug and need to switch to 1.7 or trunk, do that, but not until then.
20:24:47 <misha680> thank you djazayeri. just checking.
20:24:55 <downeym> djazayeri++
20:25:08 <djazayeri> 1.6 is probably your sweet spot for getting existing users, and using relatively recent code

Michael Downey seems to have supported him in this case.

Thank you
Misha

p.s. I am also attaching the relevant added jars as I don't know how to put them into the patch.

Hey Misha, thanks for the work done, just one request, whenever you add a patch to a ticket, you need to click on 'Request Code Review' button at the top of this page so that we can pick it up in time and have a look at the patch.

We talked about this during the design review on the September 1st 2010 and we agreed on this.